Project

General

Profile

« Previous | Next » 

Revision bb490017

Added by Leszek Koltunski about 4 years ago

Fix a long standing bug in the way we detect if a Cube or Pyraminx is solved. The reason for all those 'impossible' records being submitted.

View differences:

src/main/java/org/distorted/objects/TwistyCube.java
353 353
                 row1 = computeRow(x1,y1,z1,i);
354 354
                 row2 = computeRow(x2,y2,z2,i);
355 355

  
356
                 if( (row1==0 && row2==0) || (row1==lastLayer || row2==lastLayer) ) return true;
356
                 if( (row1==0 && row2==0) || (row1==lastLayer && row2==lastLayer) ) return true;
357 357
                 }
358 358
               return false;
359 359

  
src/main/java/org/distorted/objects/TwistyPyraminx.java
387 387
                 row1 = computeRow(x1,y1,z1,i);
388 388
                 row2 = computeRow(x2,y2,z2,i);
389 389

  
390
                 if( (row1==0 && row2==0) || (row1==numLayers || row2==numLayers) ) return true;
390
                 if( (row1==0 && row2==0) || (row1==numLayers && row2==numLayers) ) return true;
391 391
                 }
392 392
               return false;
393 393

  

Also available in: Unified diff